Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T346623 wikibase fork 1 #491

Merged
merged 3 commits into from
Oct 24, 2023
Merged

T346623 wikibase fork 1 #491

merged 3 commits into from
Oct 24, 2023

Conversation

RickiJay-WMDE
Copy link
Member

@RickiJay-WMDE RickiJay-WMDE commented Oct 17, 2023 •
edited
Loading

Remove the local wdio-wikibase patch
Make use of the fixed branch of wdio-wikibase
Folo: Once the branch of wdio-wikibase is merged into main, update this dependency again

@RickiJay-WMDE RickiJay-WMDE marked this pull request as ready for review October 17, 2023 17:05
@RickiJay-WMDE RickiJay-WMDE requested a review from a team October 17, 2023 17:05
lorenjohnson
lorenjohnson approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@lorenjohnson lorenjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RickiJay-WMDE RickiJay-WMDE merged commit 12ab4bc into main Oct 24, 2023
@RickiJay-WMDE RickiJay-WMDE deleted the T346623-wikibase-fork-1 branch October 24, 2023 09:28
RickiJay-WMDE added a commit that referenced this pull request Oct 24, 2023
@RickiJay-WMDE
T346623 wikibase fork 1 (#491)
1899331 
* Forked Package

* Remove

* Fix
RickiJay-WMDE added a commit that referenced this pull request Oct 24, 2023
@RickiJay-WMDE
T346214 await displayed (#490)
86c994a 
* awaitDisplayed

* timeout argument

* Assert and

* Rename

* Extend

* Submittable Page

* T348506 Remove Git Tagging (#492)

* Publishing Readme

* Publishing YML

* Remover

* T346623 wikibase fork 1 (#491)

* Forked Package

* Remove

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenjohnson lorenjohnson lorenjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RickiJay-WMDE @lorenjohnson